Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks #367

Open
linkdotnet opened this issue Nov 8, 2024 · 8 comments
Open

Bookmarks #367

linkdotnet opened this issue Nov 8, 2024 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@linkdotnet
Copy link
Owner

The user should be able to bookmark blog posts (probably directly on the homepage, search and inside a given blog post).

The information should be stored in the Local Storage of the user - there shouldn't be any need to store data on the server.

An open question is where the user can see all his/her bookmarked posts. That could be either an extra page or some other clever way.

@linkdotnet linkdotnet added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 8, 2024
@digitaldirk
Copy link
Contributor

I could work on this, has any work been done yet?

@linkdotnet
Copy link
Owner Author

If you are up for the challenge - I would welcome that. Much appreciated @digitaldirk

I didn’t invest any work into the topic until now.
if I can help you, let me know. Also if you have concrete ideas (especially how to present the topics to the user), i am keen to hear. I am no ux expert and need others opinion

@digitaldirk
Copy link
Contributor

I will experiment, so some of these I might not implement:

  • main page toggle to show only book marked posts
  • search page toggle to show only book marked posts
  • blog card and blog have a star/book icon button to bookmark
  • maybe new page to view/manage bookmarks? Maybe you could delete all, or share your bookmarks in some way?

I also was thinking about displaying a date edited field on blog posts and maybe the bookmark page also show this to highlight posts that have been updated that you may want to check out due to the new edits.

@linkdotnet
Copy link
Owner Author

Sounds solid. Prio 2 personally would be

search page toggle to show only book marked posts
share your bookmarks in some way?

I also was thinking about displaying a date edited field on blog posts and maybe the bookmark page also show this to highlight posts that have been updated that you may want to check out due to the new edits.

That is a good idea and I tinkered with this for a long time - not only for bookmarked posts, but for all on the home page.
The question there was more general: If the user has never read the article, should we still indicate (less code complexity) or do we store (local storage) what blog posts the user has read. For me that would be a good follow up.

@digitaldirk
Copy link
Contributor

Sorry for the delay - time just opened up to start working on this. Here's a rough proof of concept (just comma delimited strings stored in local storage)

bookmarkspoc

This feature will probably need to store a class instead (something like post id, post url,...) What would be the best value to store as the bookmarks "primary key" post url or id, or...?

We would probably need a page that would ingest bookmarks if you wanted to import them?

  • User 1 could generate some blob (json, comma delimited string, ...) then user 2 could import this.
  • Or user 1 could generate a share link which user 2 could click and get prompted to load the shared bookmarks.

@linkdotnet
Copy link
Owner Author

Hey - don't worry. There are no timelines or any pressure.

This feature will probably need to store a class instead

Wouldn't an array of blog post IDs not be sufficient for our case?

We would probably need a page that would ingest bookmarks if you wanted to import them?

Interesting case. If you want, we can exclude it for now. Sharing a link is more common than a collection of links (I guess?).

I can also add a bookmark icon to our icon-collection (there isn't any suitable icon at the moment) if you need this.

@digitaldirk
Copy link
Contributor

@linkdotnet I will need to drop this for now as I don't have the bandwidth currently.

I may be able to come back to this if it hasn't been picked up in the future.

Thank you

@linkdotnet
Copy link
Owner Author

Don't worry and no problem. That is how life is and no need to aplogize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants