Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart Price rule discounts incorrect value when shipping is included and an item in the cart is non-taxable #39531

Open
1 of 5 tasks
techsteamdesk opened this issue Jan 10, 2025 · 6 comments
Labels
Area: Tax Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Reported on 2.4.6-p8 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@techsteamdesk
Copy link

Preconditions and environment

  1. Magento Open Source 2.4.6-p8 without sample data is installed.
  2. No custom modules or theme customisation
  3. Default Luma theme
  4. Set up tax rules and tax rates and zones with a tax rate of 20% for all UK Addresses.
  5. Set up the sales > tax configuration as per the attached screenshot. Note that there are no warnings of tax rounding errors.
  6. Create a some new products. Create two simple products one that is taxable and one that is not. Create a configurable product with taxable and non-taxable child products. Add all the products to a test category.
  7. Set up and enable the flat rate shipping method for £4.80.
  8. Create a Cart Price rule that applies a fixed value to the whole cart up to £60 and has the ‘Apply to Shipping Amount’ setting set to yes. See attached screenshot for details.
Screenshot 2025-01-09 at 3 46 33 PM Screenshot 2025-01-10 at 10 10 25 AM

Steps to reproduce

  1. Navigate to storefront as a guest.
  2. Open Test Category.
  3. Click "Add to Cart" on a Product that is not taxable.
  4. Open mini shopping cart and click "View and edit cart".
  5. Change the quantity in cart so that it exceeds the £60 coupon discount.
  6. Apply the previously configured coupon code.

Expected result

Order is discounted by £60

Actual result

Order is discounted by a different amount.
Screenshot 2025-01-10 at 10 06 58 AM

Additional information

If you change the product in the cart to one that is taxable with otherwise identical conditions the Order is correctly discounted by £60:
Screenshot 2025-01-10 at 10 13 13 AM

However any combination of products in the cart that include a tax free product causes the discount to be incorrect:
Screenshot 2025-01-10 at 10 16 38 AM

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Jan 10, 2025

Hi @techsteamdesk. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.6-p8 Indicates original Magento version for the Issue report. label Jan 13, 2025
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Jan 13, 2025
@engcom-Bravo engcom-Bravo self-assigned this Jan 13, 2025
Copy link

m2-assistant bot commented Jan 13, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Copy link

m2-assistant bot commented Jan 15, 2025

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

Hi @techsteamdesk ,

Thanks for your reporting and collaboration.
We have re-verified the issue in latest 2.4-develop instance and the issue is reproducible.
Kindly refer the screenshots.

Steps to reproduce :

  1. Navigate to storefront as a guest.
  2. Open Test Category.
  3. Click "Add to Cart" on a Product that is not taxable.
  4. Open mini shopping cart and click "View and edit cart".
  5. Change the quantity in cart so that it exceeds the £60 coupon discount.
  6. Apply the previously configured coupon code.

Image

Observe Cart Price rule discounts incorrect value when shipping is included and an item in the cart is non-taxable.

Thanks.

@engcom-Delta engcom-Delta added Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Tax labels Jan 15, 2025
@engcom-Delta engcom-Delta moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Jan 15, 2025
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13715 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Jan 15, 2025

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Jan 16, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Jan 16, 2025
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 21, 2025
@github-project-automation github-project-automation bot moved this to Ready for Grooming in Backlog Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tax Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Reported on 2.4.6-p8 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Ready for Grooming
Development

No branches or pull requests

5 participants