Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different default direction in sorting for category page or catalog search #39545

Open
1 of 5 tasks
venchiarutti opened this issue Jan 15, 2025 · 3 comments
Open
1 of 5 tasks
Assignees
Labels
feature request Issue: ready for confirmation Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@venchiarutti
Copy link
Contributor

Preconditions and environment

  • All versions

The category page default direction is defined by

When it is a catalog search magento 2 uses the value from this piece of code in the file: vendor/magento/module-catalog-search/Block/Result.php

public function setListOrders()
{
$category = $this->catalogLayer->getCurrentCategory();
/* @var $category \Magento\Catalog\Model\Category */
$availableOrders = $category->getAvailableSortByOptions();
unset($availableOrders['position']);
$availableOrders['relevance'] = __('Relevance');

$this->getListBlock()->setAvailableOrders(
$availableOrders
)->setDefaultDirection(
'desc'
)->setDefaultSortBy(
'relevance'
);

return $this;
}

But when it is in the category page it uses the value from vendor/magento/module-catalog/Block/Product/ProductList/Toolbar.php

/**

  • Default direction
  • @var string
    */
    protected $_direction = ProductList::DEFAULT_SORT_DIRECTION;

So it has a different default order depending on where...

The correct for such important feature should have configuration for both cases in the admin, but having a different default direction with the same toolbar understanding both as the default one is causing issues

Steps to reproduce

  1. Sort by something in the catalog search
  2. Sort by something in the category page
  3. See that the direction is inverted

This can be more clearly checked by for example adding an eav_attribute to be used as sort option, in the catalog it will be in a direction and in category another one

Expected result

The correct would be having configurations for both cases

Actual result

Different sorting direction in catalog search and category page

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Jan 15, 2025

Hi @venchiarutti. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Jan 29, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

Hi @venchiarutti,

Thanks for your reporting and collaboration.

We have gone through with the description and seems to be an improvement to proceed further we are marking this as Feature Reauest.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue: ready for confirmation Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
Status: Ready for Grooming
Development

No branches or pull requests

3 participants