Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document "dilation-abilities" key in the versions message #37

Open
vu3rdd opened this issue Apr 21, 2023 · 3 comments
Open

document "dilation-abilities" key in the versions message #37

vu3rdd opened this issue Apr 21, 2023 · 3 comments

Comments

@vu3rdd
Copy link
Contributor

vu3rdd commented Apr 21, 2023

Python client sends a key called dilation-abilities in the versions message jSON payload. This seem undocumented in the dilation specification.

{'can-dilate': ['1'], 'dilation-abilities': [{'type': 'direct-tcp-v1'}, {'type': 'relay-v1'}], 'app_versions': {}}
@vu3rdd
Copy link
Contributor Author

vu3rdd commented Apr 25, 2023

The versions spec documentation refers to this as abilities? Or am I confusing it?

There is also some discrepancy with that document referring to abilities like dilation-v1, which the dilation spec doesn't define.

@meejah
Copy link
Member

meejah commented Apr 25, 2023

As currently written, the code sends versions as strings -- I think we should send integers (well "numbers" in JSON speak) to be more clear. The "please" message also doesn't send the "use-version" that it is supposed to -- I think this is a thing we do want to send. Perhaps it's missing because there's only a single version currently, but being consistent here now I think has lots of benefit.

@meejah
Copy link
Member

meejah commented May 6, 2023

Actually, I did find a reason that strings are used for versions: then implementations can use this for "non-official" or experimental versions easily without trying to figure out "a number" to give it.

The preference order comes from the order in the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants