Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linestring viz #81

Closed
ryanbaumann opened this issue Mar 26, 2018 · 5 comments
Closed

Add linestring viz #81

ryanbaumann opened this issue Mar 26, 2018 · 5 comments

Comments

@ryanbaumann
Copy link
Contributor

ryanbaumann commented Mar 26, 2018

Create a new Viz class tyle, LinestringViz, that allows a user to create a line map from a geojson source or a vector tile source. Follow the same techniques used to make the Choropleth Viz. #40

Example:

68747470733a2f2f636c2e6c792f3330304832413074323131512f646f776e6c6f61642f496d616765253230323031372d30322d31342532306174253230362e31332e3338253230504d2e706e67

@akacarlyann
Copy link
Collaborator

akacarlyann commented Apr 14, 2018

@ryanbaumann in terms of styled elements of a LineStringViz, I'm thinking color and width could both be data-driven. This is slightly different from the Choropleth approach, which defines a single line color/stroke/width for the entire map. Anything else you want to add? I can open a PR this afternoon for this.

@ryanbaumann
Copy link
Contributor Author

Agree with color and width being the two major features to control, @akacarlyann. It's similar to the Choropleth, just Choropleth uses color and height, while Linestring uses color and width. Obviously excited to review a PR, if you have one!

@akacarlyann akacarlyann mentioned this issue Apr 15, 2018
4 tasks
@akacarlyann
Copy link
Collaborator

Rough start at #92. Found I might want to generalize mapboxgl.utils.height_map from use in ChoroplethViz first too.

@ryanbaumann
Copy link
Contributor Author

Great @akacarlyann. We can open up a separate PR to address the utils function sprawl before the next release. Agree we need to keep the utils functions as generic and re-usable across visualizations as possible.

@ryanbaumann
Copy link
Contributor Author

Closed in #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants