Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for all exported functions #18

Open
l50 opened this issue Oct 6, 2019 · 2 comments
Open

Add unit tests for all exported functions #18

l50 opened this issue Oct 6, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@l50
Copy link
Contributor

l50 commented Oct 6, 2019

Exported functions (functions that start with a capital letter) should have unit tests.

@l50 l50 self-assigned this Oct 6, 2019
@l50 l50 added the enhancement New feature or request label Oct 6, 2019
@l50 l50 added good first issue Good for newcomers and removed enhancement New feature or request labels Jan 5, 2020
@l50 l50 removed their assignment Jan 5, 2020
@tlabruyere
Copy link

tlabruyere commented Jan 13, 2020

list of function that are exported:

  • TestBackupManifest
  • TargetAgents
  • CreateFolders
  • FileExists
  • GrepFile
  • GetFileAndDirList
  • File2lines
  • InsertStringToFile
  • LinesFromReader
  • TarFiles
  • ReplLineInFile
  • TrackChanges
  • RemoveTracker
  • GetHostname
  • GetLocalIP
  • StartServer
  • LoadSettings
  • SliceUniqMap
  • StringInSlice
  • CpFile
  • Cd
  • FindFiles
  • FindBin
  • AskUserQuestion
    in files:
    cmd/mose/puppet/main_test.go
    pkg/chefutils/chefutils.go
    pkg/moseutils/fileutils.go
    pkg/moseutils/netutils.go
    pkg/moseutils/settings.go
    pkg/moseutils/sliceutils.go
    pkg/moseutils/sysutils.go
    pkg/moseutils/ui.go

@l50
Copy link
Contributor Author

l50 commented Jan 13, 2020

Yeah, with the exception of those in cmd/mose/puppet/main_test.go, all of those functions need unit tests implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants