Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Dashboard - Create sales channel error toast has success type #11023

Open
Avia-Code opened this issue Jan 17, 2025 · 1 comment · May be fixed by #11019
Open

[Bug]: Dashboard - Create sales channel error toast has success type #11023

Avia-Code opened this issue Jan 17, 2025 · 1 comment · May be fixed by #11019
Labels
status: needs triaging version: 2.0

Comments

@Avia-Code
Copy link
Contributor

Avia-Code commented Jan 17, 2025 •
edited
Loading

Node.js version

22.13.0

Database and its version

PostgreSQL 16.2

Operating system name and version

MacOS Sonoma 14.3

Browser name

No response

What happended?

When create sales channel in dashboard and get from api error as a result error message into success popup

Expected behavior

When create sales channel in dashboard and get from api error as a result error message should be into error popup

Actual behavior

When create sales channel in dashboard and get from api error as a result error message should be into success popup

Link to reproduction repo

medusa/packages/admin/dashboard/src/routes/sales-channels/sales-channel-create/components/create-sales-channel-form/create-sales-channel-form.tsx

Line 55 in 5faf48b

onError: (error) => toast.success(error.message),

@Avia-Code
Copy link
Contributor Author

Avia-Code commented Jan 17, 2025 •
edited
Loading

I have already fixed bug at #11019

@Avia-Code Avia-Code linked a pull request Jan 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs triaging version: 2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dashboard): create sales channel toast type Avia-Code/medusa
1 participant
@Avia-Code