Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish to JSR alongside NPM #1841

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Publish to JSR alongside NPM #1841

wants to merge 8 commits into from
+39 −6

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Jan 28, 2025

Pull Request

Let's try and publish to JSR as well.

To do for @curquiza:

And that should be it. If any issues arise we can discuss it, or maybe I could get some access to this JSR scope and package, see what else we can properly set up there.

Related issue

Fixes #1792

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@flevi29 flevi29 added enhancement New feature or request maintenance Issue about maintenance (CI, tests, refacto...) labels Jan 28, 2025
@flevi29 flevi29 requested a review from curquiza January 28, 2025 09:55
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.85%. Comparing base (792ce67) to head (52ff694).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1841   +/-   ##
=======================================
  Coverage   98.84%   98.85%           
=======================================
  Files          17       17           
  Lines        1565     1568    +3     
  Branches      338      338           
=======================================
+ Hits         1547     1550    +3     
  Misses         18       18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza Awaiting requested review from curquiza

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish to JSR alongside NPM
1 participant
@flevi29