AwsApiProxyTestServer doesn't close the web server handler's context and leaks connections

[dbmeneses]

Expected Behavior

When AwsApiProxyTestServer is closed, it should release all of its resources.

Actual Behaviour

AwsApiProxyTestServer creates a custom Jetty web server handler AwsProxyHandler. This handler has its own application context. AwsApiProxyTestServer never calls AwsProxyHandler.destroy(), so the application context is never stopped. Since the application context will typically contain a data source, we also have leaked DB connections as a result.

Steps To Reproduce

No response

Environment Information

No response

Example Application

No response

Version

4.3.2

[sdelamo]

do you have a sample application @dbmeneses ?

[dbmeneses]

I don't, but I'll try to provide one next week.

[dman-vendavo]

In AwsApiProxyTestServer the handler is being created:
this.server.setHandler(new AwsProxyHandler(this.applicationContext)); this.server.start();
As a part of this invocation, brand new application context is started. However this context is never stopped, because the method AwsProxyHandler.destroy() is never invoked.