Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Github] PRs missing build CI checks #36946

Open
htcfreek opened this issue Jan 17, 2025 · 2 comments
Open

[Github] PRs missing build CI checks #36946

htcfreek opened this issue Jan 17, 2025 · 2 comments
Assignees
@crutkas @jaimecbernardo
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Bug Something isn't working Needs-Team-Response An issue author responded so the team needs to follow up Priority-0 Bugs that we consider release-blocking/recall-class (P0) Status-Reproducible This issue was reproduced by a maintainer

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Jan 17, 2025 •
edited
Loading

Repository Branch

main

❌ Actual Behavior

The build ci checks aren't running anymore after updating PRs against current main. Why?

xref: #33703

Image

✔️ Expected Behavior

Build CI checks are executed after pushing changes.
@htcfreek htcfreek added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Bug Something isn't working Needs-Team-Response An issue author responded so the team needs to follow up Priority-0 Bugs that we consider release-blocking/recall-class (P0) Status-Reproducible This issue was reproduced by a maintainer labels Jan 17, 2025
@DHowett
Copy link
Member

DHowett commented Jan 17, 2025

Unfortunately, we've had to switch to a security mode that requires a team member to comment on a PR before the CI will kick in. Sorry. You'll probably see this across all the Microsoft projects you contribute to in the coming weeks. 😦

@htcfreek
Copy link
Collaborator Author

htcfreek commented Jan 17, 2025 •
edited
Loading

Is this a temporary thing? What is the reason for this decision?

Wouldn't it make sense to block merge until ci succeds? (I have in mind that GitHub supports runs after approvals or something similar.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crutkas crutkas

@jaimecbernardo jaimecbernardo

Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Bug Something isn't working Needs-Team-Response An issue author responded so the team needs to follow up Priority-0 Bugs that we consider release-blocking/recall-class (P0) Status-Reproducible This issue was reproduced by a maintainer
Projects
5. Needs Attention
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DHowett @crutkas @jaimecbernardo @htcfreek