Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at gemini internals for fixes/enhancements #49

Open
giorgi-ghviniashvili opened this issue May 13, 2021 · 2 comments
Open

Look at gemini internals for fixes/enhancements #49

giorgi-ghviniashvili opened this issue May 13, 2021 · 2 comments
Assignees

Comments

@giorgi-ghviniashvili
Copy link
Collaborator

I think I should start reading gemini source code and see how it works to be able to fix some internal things. For example this.

Also #48 is related to gemini recommendations, which does not correctly gets recommended gemini animation spec. Would be better to a least debug and find why it does not work correctly.

For example, it always gets encode: { enter: true, exit: true, update: true }, even if I set them to false in options.

@giorgi-ghviniashvili
Copy link
Collaborator Author

update about #48, I was initializing recommendation options incorrectly. Fixed it now.

@jhofman jhofman changed the title Look inside how gemini works Look at gemini internals for fixes/enhancements May 17, 2021
@jhofman
Copy link
Contributor

jhofman commented Jul 15, 2021

we agreed that this is useful at some point, but it's a big investment in time. we'll hold off on this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants