Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement AccessibilityInfo::isHighTextContrastEnabled() in AccessibilityInfoModule #14099

Open
Yajur-Grover opened this issue Nov 8, 2024 · 1 comment
Open

Implement AccessibilityInfo::isHighTextContrastEnabled() in AccessibilityInfoModule #14099

Yajur-Grover opened this issue Nov 8, 2024 · 1 comment
Assignees
@Yajur-Grover
Labels
Area: Accessibility enhancement Integration Follow-up Parity: React Native RNW does not look or behave like upstream RN platforms
Milestone
Next

Comments

@Yajur-Grover
Copy link
Contributor

Problem Description

A new method isHighTextContrastEnabled(std::function<void(bool)> const &onSuccess) method was added from upstream here: facebook/react-native#46746. We will need to implement this method in RNW - currently it is only executing onSuccess(false).

Link to the integration where the error originated

#13996

Link to commit

facebook/react-native#46746

Forked files

No response

Upstream PR

No response

Build Configuration

None
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 8, 2024
@Yajur-Grover Yajur-Grover mentioned this issue Nov 8, 2024
Merged
@chrisglein chrisglein added this to the Next milestone Nov 11, 2024
@chrisglein chrisglein added enhancement Parity: React Native RNW does not look or behave like upstream RN platforms labels Nov 11, 2024
@chrisglein
Copy link
Member

@Yajur-Grover Is this in the public RN core docs yet? Was looking for a link to the prop description there.
But yes, we'll want to link up to the appropriate Windows standard.

@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yajur-Grover Yajur-Grover

Labels
Area: Accessibility enhancement Integration Follow-up Parity: React Native RNW does not look or behave like upstream RN platforms
Projects
None yet
Milestone
Next
Development

No branches or pull requests
2 participants
@chrisglein @Yajur-Grover