Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Chat History Reducer is possibly in the wrong spot #10203

Open
wmeints opened this issue Jan 16, 2025 · 0 comments
Open

.Net: Chat History Reducer is possibly in the wrong spot #10203

wmeints opened this issue Jan 16, 2025 · 0 comments
Labels
.NET Issue or Pull requests regarding .NET code triage

Comments

@wmeints
Copy link

wmeints commented Jan 16, 2025

I noticed that the IChatHistoryReducer was graduated from a sample to the agents layer of the framework. However, I feel that this is the wrong place to put it.

On the one hand, it makes sense to add it to an agent because agents are often used in chat scenarios. I understand that. However, I'm using chat history in non-chat scenarios too, and I don't want to use the agent framework in my application. I consider many of my applications with Semantic Kernel workflows rather than agents.

Would it be possible to consider adding the chat history reduction logic to the core of Semantic Kernel rather than the agent layer?

@moonbox3 moonbox3 changed the title Chat History Reducer is possibly in the wrong spot .Net: Chat History Reducer is possibly in the wrong spot Jan 16, 2025
@moonbox3 moonbox3 added the .NET Issue or Pull requests regarding .NET code label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code triage
Projects
Status: No status
Development

No branches or pull requests

3 participants