Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running tests: this version of ember-auto-import requires the app to have a dependency on webpack #145

Open
Gorzas opened this issue Jul 5, 2021 · 10 comments

Comments

@Gorzas
Copy link
Contributor

Gorzas commented Jul 5, 2021

Could anyone try if you have the same problem? I believe it's related to the last release of EmberJS (3.27) when doing npm run test:

[ember-auto-import] this version of ember-auto-import requires the app to have a dependency on webpack 

I found it when trying to solve this PR. It seems to have a very easy solution but I need to know I'm not the only one having this issue.

@patrickberkeley
Copy link

webpack is required for ember-auto-import v2 so I'm assuming somehow auto import was upgraded. I don't see ember-auto-import v2 as a requirement for ember 3.27, so is there a chance you upgraded it on your own?

@Gorzas
Copy link
Contributor Author

Gorzas commented Jul 6, 2021

@patrickberkeley I'm going to rm node_modules and try again. I also have seen that package-lock.json gets updated after doing an npm install, don't know if it's related.

@Gorzas
Copy link
Contributor Author

Gorzas commented Jul 6, 2021

The ember-auto-import dependency is directly in the package.json: https://github.com/minutebase/ember-can/blob/master/package.json#L68

@patrickberkeley
Copy link

Ah that would do it :-P Pretty sure a webpack config is required then.

Gorzas added a commit to Gorzas/ember-can that referenced this issue Jul 6, 2021
@Exelord
Copy link
Collaborator

Exelord commented Jul 7, 2021

Hmm, all tests are passing for me locally without any issues. Same for CI. What version of node and npm are you using? Im testing on the latest.

@Gorzas
Copy link
Contributor Author

Gorzas commented Jul 7, 2021

@Exelord Could try to do rm -rf node_modules and install the dependencies again, please?

@Exelord
Copy link
Collaborator

Exelord commented Jul 7, 2021

Yes, that's what I did. All works just fine. CI confirms that. :)

@Gorzas
Copy link
Contributor Author

Gorzas commented Jul 7, 2021

I'm using node 12.22.1 and npm 6.14.12

@Exelord
Copy link
Collaborator

Exelord commented Jul 7, 2021

Try with latest node 14 or 16 and npm 7.19^

@Gorzas
Copy link
Contributor Author

Gorzas commented Jul 15, 2021

@Exelord It works with Node 14/16 and npm 7.19. I have updated the PR upgrading the requirement of Node version: #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants