-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to exempt some resolvers from tracing #859
Comments
Construction option (like we are already doing with |
I've taken a quick look and it is easy to do this way but the |
Yeah, we should drop For now we could have both options but raise an error if custom tracing filter is set together with |
Actually, I've found a way to implement extensions that is much faster that what we currently have, and I would like to implement it in future release of Ariadne, but I've been busy with other commitments recently that prevented me from doing so. |
Faster extensions landed in Ariadne 0.20, but as I've mentioned on Ariadne's blog, there's still utility in having an option to remove fields from tracing extensions for removing the especially noisy resolvers from APM. |
The default behavior of only tracing custom resolvers is great 95% of the time, however there is a case for not to trace certain custom resolvers as well.
We have a few simple custom resolvers that can be called up to a couple thousand times per request where the tracing overhead becomes significant. Also, in our case they don't do meaningful work that would warrant tracing them.
Right now I see two ways to implement a workaround in our code-base without touching ariadne itself:
ariadne.contrib.tracing.should_trace
function_ariadne_alias_resolver
attribute to our own resolvers, disguising them as alias resolvers which are already exempt fro tracing.The first two approaches are brittle and can break upon any update to ariadne. We can go forward using the third approach but we think it'd make sense to add this functionality in ariadne itself.
I'd like to contribute support for this functionality in ariadne if you accept my reasoning for the need of it. My plan is to add a
filter
callable to the tracing extensions that can look-up the field in a block-list or perform any other custom logic.An even less intrusive change could also be just adding a
should_trace
method in the tracing extensions that can be overridden in a subclass, instead of using a non-member function.The text was updated successfully, but these errors were encountered: