Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download a FileSet's ExtractedText file #1423

Closed
2 tasks done
conorom opened this issue Dec 8, 2017 · 3 comments
Closed
2 tasks done

Download a FileSet's ExtractedText file #1423

conorom opened this issue Dec 8, 2017 · 3 comments

Comments

@conorom
Copy link
Contributor

conorom commented Dec 8, 2017

  • Enable the downloading of a FileSet's ExtractedText file
  • use extracted_text as the file URL param

This ties in with #1261

@mbakeryo
Copy link

mbakeryo commented Jan 8, 2018

I've put together a pretty lame example of multiple format types on one asset page with the OCR disclaimer. More to do here, but this is a start to a document to try and determine the best way to move forward: https://docs.google.com/document/d/1KDBh5jCth5R53MUPli8ZjQxy1asfN9KE13-EaM7X_hg/edit.

I appreciate any comments you may have.

This is also related to #1429

@mbakeryo
Copy link

This is blocked by Apex - waiting for the final files.

@conorom
Copy link
Contributor Author

conorom commented Jan 18, 2018

I'm reissuing a rebased PR for this work where the method that decides whether the FileSet's extracted_text association has a non-zero-size file available always returns false in production. I've tested that the download button no longer appears on staging assets with extracted text.

If nothing else, the code provides a place to work from if and when we want to add the downloading of custom/new FileSet associations (accessible_version or what have you).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants