You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This prevents a developer from having these properties themselves unless they override the handlers.
E.g.
draggable: {get: function(){//My own draggable logic},set: function(value){//My own draggable logic}},//Required to prevent default drag functionality.handleDraggableChange: {value: function(){}}
This broke backwards compatibility in an existing component of ours. Is there a reason that draggable and droppable can't be handled via getters and setters? If there is a compelling one, we can fix this ourselves in using the strategy above. However, if there is not, I vote they be converted to getters/setters. E.g.
The registration/unregistration of
Component#droppable
andComponent#draggable
is currently handled via property change listeners:https://github.com/montagejs/montage/blob/master/ui/component.js#L1848-L1849
https://github.com/montagejs/montage/blob/master/ui/component.js#L2936-L2954
This prevents a developer from having these properties themselves unless they override the handlers.
E.g.
This broke backwards compatibility in an existing component of ours. Is there a reason that
draggable
anddroppable
can't be handled via getters and setters? If there is a compelling one, we can fix this ourselves in using the strategy above. However, if there is not, I vote they be converted to getters/setters. E.g.The text was updated successfully, but these errors were encountered: