Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: TSL.SpriteNodeMaterial is not a constructor #30458

Open
WREQI opened this issue Feb 5, 2025 · 14 comments
Open

Playground: TSL.SpriteNodeMaterial is not a constructor #30458

WREQI opened this issue Feb 5, 2025 · 14 comments
Assignees

Comments

@WREQI
Copy link

WREQI commented Feb 5, 2025

Description

Image

Reproduction steps

Code

// code goes here

Live example

Screenshots

No response

Version

173

Device

No response

Browser

No response

OS

No response

@WREQI
Copy link
Author

WREQI commented Feb 5, 2025

Image

@mrdoob mrdoob added the WebGPU label Feb 5, 2025
@mrdoob mrdoob changed the title node editor bug Node editor: TSL.SpriteNodeMaterial is not a constructor Feb 5, 2025
@WREQI
Copy link
Author

WREQI commented Feb 5, 2025

Image bug 2

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 5, 2025

The namespace issue with SpriteNodeMaterial should be fixed via b5d7c74.

Not sure about the other error in #30458 (comment) though.

Besides, it seems TimerEditor still relies on the outdated timerLocal().

import { timerLocal } from 'three/tsl';

@WREQI
Copy link
Author

WREQI commented Feb 5, 2025

Can you let me know in advance how to fix it? I'm good to use locally without having to wait for a new version to be released。

@WREQI
Copy link
Author

WREQI commented Feb 5, 2025

Image bug 2

This case is correct in 164 and older versions

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 5, 2025

Can you let me know in advance how to fix it? I'm good to use locally without having to wait for a new version to be released。

My commit b5d7c74 just updated the serialized scene so this fix is easy to apply on your local computer. All you have to do is update the asset.

The TimerEditor issue require changes in the code base. The other runtime error probably as well. It's best to wait for @sunag's feedback on those issues.

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 5, 2025

Do you mind exporting the material configuration that produces the second bug and share the JSON in this issue?

@sunag
Copy link
Collaborator

sunag commented Feb 5, 2025

I'm analyzing here, Playground is not yet compatible with TSL functions, and many of the previous Nodes like the checker were converted to TSL Fn.

@sunag sunag changed the title Node editor: TSL.SpriteNodeMaterial is not a constructor Playground: TSL.SpriteNodeMaterial is not a constructor Feb 5, 2025
@WREQI
Copy link
Author

WREQI commented Feb 6, 2025

Image
All cases are exported and then imported, and an error is reported @sunag

@sunag sunag added the Bug label Feb 6, 2025
@WREQI
Copy link
Author

WREQI commented Feb 6, 2025

Image
Online code modifications do not take effect @sunag

@WREQI
Copy link
Author

WREQI commented Feb 6, 2025

Image
Image
Changing the TeapotGeometry in the json file to boxGeometry does not take effect

const { TeapotGeometry } = await import( 'three/addons/geometries/TeapotGeometry.js' );
const geometryTeapot = new TeapotGeometry( 1, 18 );

const geometryTeapot = new THREE.BoxGeometry( 100, 100, 100 );

fresnel.json

@WREQI
Copy link
Author

WREQI commented Feb 6, 2025

@sunag As shown in the above two pictures, two new bugs

@WREQI
Copy link
Author

WREQI commented Feb 6, 2025

Do you mind exporting the material configuration that produces the second bug and share the JSON in this issue?
Cannot share due to import/export error

#30458 (comment)

@WREQI
Copy link
Author

WREQI commented Feb 7, 2025

Image

  1. The value of time is not dynamically refreshed
  2. Cannot choose to add file node
  3. File node input box, cannot modify file path

Image

  1. New and added map display error in the upper right corner
    @sunag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants