Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argentina - Wrong public holiday #685

Closed
JuanIgnacioPayo opened this issue Sep 23, 2024 · 7 comments
Closed

Argentina - Wrong public holiday #685

JuanIgnacioPayo opened this issue Sep 23, 2024 · 7 comments
Assignees
Labels

Comments

@JuanIgnacioPayo
Copy link

JuanIgnacioPayo commented Sep 23, 2024

Affected country

Argentina

Affected public holiday

many holidays

Source of the information

https://www.argentina.gob.ar/interior/feriados-nacionales-2024

More information

There are many affected holidays, please check the dates with the provided official link https://www.argentina.gob.ar/interior/feriados-nacionales-2024. Thank you

@tinohager
Copy link
Member

I am happy to correct errors, but please name specific holidays where errors exist. Then we can also fix them. But simply sending a list is unfortunately not the way we work here.

@tinohager tinohager changed the title Wrong public holiday Argentin - Wrong public holiday Sep 23, 2024
@JuanIgnacioPayo
Copy link
Author

JuanIgnacioPayo commented Sep 23, 2024 via email

@tinohager tinohager changed the title Argentin - Wrong public holiday Argentina - Wrong public holiday Sep 25, 2024
tinohager added a commit that referenced this issue Sep 25, 2024
tinohager added a commit that referenced this issue Sep 30, 2024
* Argentina - Fix Weekday shift logic

- #685

* remove shift logic for the weekend
@tinohager
Copy link
Member

@JuanIgnacioPayo The public holidays should now fit better, the “tourist public holidays” would require a manual entry every year. I have not yet dealt with this.

@JuanIgnacioPayo
Copy link
Author

JuanIgnacioPayo commented Oct 2, 2024 via email

@pmxgit
Copy link

pmxgit commented Oct 7, 2024

Hello,

I want to report an issue with this Holiday API for Argentina 2024: https://date.nager.at/api/v3/PublicHolidays/2024/AR

In this API we have duplicated a holiday at February 12 for 2024

"date":"2024-02-12","localName":"Carnaval","name":"Carnival","countryCode":"AR","fixed":false,"global":true,"counties":null,"launchYear":null,"types":["Public"]},{"date":"2024-02-12","localName":"Carnaval","name":"Carnival","countryCode":"AR","fixed":false,"global":true,"counties":null,"launchYear":null,"types":["Public"]}

We have 2 days for Carnaval and they are February 12 and February 13.

I will apreciate if you can change this.

Thank you very much!

@tinohager
Copy link
Member

@pmxgit I have revised the rules again.

@tinohager tinohager self-assigned this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants