-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argentina - Wrong public holiday #685
Comments
I am happy to correct errors, but please name specific holidays where errors exist. Then we can also fix them. But simply sending a list is unfortunately not the way we work here. |
Hi Tino, good afternoon, thank you very much for your quick response.
I didn't specify much before because I didn't know how it worked, I apologize. Below I will indicate the dates on which the official Argentine government calendar differs from the holiday calendar of your API.
Thank you very much for the service you provide and the responsibility with which
you work.
- Monday, April 1st was a holiday bridge for tourism purposes.
- Friday, June 21st was a holiday bridge for tourism purposes.
- August 17th fell on a Saturday and the holiday was not moved.
- Therefore August 19th was not a holiday.
- Monday, October 14th is not a holiday.
- The holiday on Saturday, October 12th was moved to Friday, October 11th.
- Sovereignty Day is on November 20th but since it fell on a Wednesday, they decided to move it to Monday, November 18th.
|
* Argentina - Fix Weekday shift logic - #685 * remove shift logic for the weekend
@JuanIgnacioPayo The public holidays should now fit better, the “tourist public holidays” would require a manual entry every year. I have not yet dealt with this. |
Thank you very much Tino! Your job was great. Now i can work whit this much
better. Please indicate me where i can buy you a virtual coffee. Have a
nice day
El mié, 2 de oct de 2024, 10:18 a. m., Tino Hager ***@***.***>
escribió:
… @JuanIgnacioPayo <https://github.com/JuanIgnacioPayo> The public holidays
should now fit better, the “tourist public holidays” would require a manual
entry every year. I have not yet dealt with this.
—
Reply to this email directly, view it on GitHub
<#685 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVFECBBG2FFUBTWRQPA3EI3ZZPXCHAVCNFSM6AAAAABOWW4G6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBYGYZDKMBUGI>
.
You are receiving this because you were mentioned.Message ID: <nager/Nager
.***@***.***>
|
Hello, I want to report an issue with this Holiday API for Argentina 2024: https://date.nager.at/api/v3/PublicHolidays/2024/AR In this API we have duplicated a holiday at February 12 for 2024 "date":"2024-02-12","localName":"Carnaval","name":"Carnival","countryCode":"AR","fixed":false,"global":true,"counties":null,"launchYear":null,"types":["Public"]},{"date":"2024-02-12","localName":"Carnaval","name":"Carnival","countryCode":"AR","fixed":false,"global":true,"counties":null,"launchYear":null,"types":["Public"]} We have 2 days for Carnaval and they are February 12 and February 13. I will apreciate if you can change this. Thank you very much! |
@pmxgit I have revised the rules again. |
Affected country
Argentina
Affected public holiday
many holidays
Source of the information
https://www.argentina.gob.ar/interior/feriados-nacionales-2024
More information
There are many affected holidays, please check the dates with the provided official link https://www.argentina.gob.ar/interior/feriados-nacionales-2024. Thank you
The text was updated successfully, but these errors were encountered: