Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML-based admin group membership not possible since v6 #813

Open
blizzz opened this issue Feb 22, 2024 · 1 comment
Open

SAML-based admin group membership not possible since v6 #813

blizzz opened this issue Feb 22, 2024 · 1 comment

Comments

@blizzz
Copy link
Member

blizzz commented Feb 22, 2024

I updated SAML plugin to v6.1 (It seems it can't be reverted back anymore). Now we have two admin groups. I think one is local admin groups with super admin users, and the other one SAML_admin with the users from SAML. This broke admin group assignments.
Is there no way to make a SAML user super admin anymore with the new Group Backend?

Originally posted by @GaugeTheory in #810 (comment)

@blizzz
Copy link
Member Author

blizzz commented Feb 22, 2024

On the hand it could be considered acceptable for a group called "admin" to not create an own one. But removal would not work. Instead of having exceptions, it's better to implement IIsAdmin interface, so that the SAML backend can say itself who is admin and who not. Would need yet another setting field to declare the admin group(s).

@blizzz blizzz self-assigned this Feb 22, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Feb 22, 2024
@blizzz blizzz moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Feb 22, 2024
@blizzz blizzz changed the title SAML-based admin group SAML-based admin group membership not possible since v6 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📄 To do (~10 entries)
Development

No branches or pull requests

1 participant