Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing values in dOcc* and dNmixture* distributions #29

Merged
merged 11 commits into from
Oct 1, 2024

Conversation

kenkellner
Copy link
Contributor

@kenkellner kenkellner commented Sep 12, 2024

Missing values in x are now ignored in dOcc* and dNmixture* distributions. If all of x is NA, the functions return 1 (or 0 if log=TRUE). All of these distributions also continue to work with AD.

There are many additional copies of the following note now when installing(?)/loading(?) the package (#26):

[Note] Detected use of function(s) that are not supported for derivative tracking in a function or method for which `buildDerivs` has been requested: is.na.

Copy link
Collaborator

@dochvam dochvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great. N-mixture and Occ should now handle NAs and all tests are passing. For now we are ignoring the NOTE about "is.na" as this is coming from NIMBLE's side of things and might be addressed on that end.

@dochvam dochvam merged commit 5b6c41d into nimble-dev:master Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants