Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the scripts optional as part of an extra #23

Closed
DetachHead opened this issue Apr 25, 2024 · 1 comment · Fixed by #25
Closed

make the scripts optional as part of an extra #23

DetachHead opened this issue Apr 25, 2024 · 1 comment · Fixed by #25
Assignees

Comments

@DetachHead
Copy link
Contributor

i'm considering switching to this project from nodejs-bin. it makes the node, npm and npx scripts optional and only installs them if you install the cmd extra:

pip install 'nodejs-bin[cmd]'

that's useful in my case because i only need to call node programmatically and not via the command line, and i'd prefer users of my package to not unknowingly have a node binary added to their path.

@njzjz
Copy link
Owner

njzjz commented Apr 25, 2024

We may have two options to do it (like scikit-build/cmake-python-distributions#80 (comment)). One is

  • nodejs-wheel[cmd]
  • nodejs-wheel

Another one is

  • nodejs-wheel
  • nodejs-wheel-binaries
    (nodejs-wheel is based on nodejs-wheel-binaries)

I prefer the second one, as it has no breaking change to nodejs-wheel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants