You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just used fetch-blob in one of my projects and I noticed in snapshot tests that the string representation of the File class here is simplified in contrast to the native one:
It seems to be deliberate, as there is a test covering it:
I am not completely sure yet, where to start, as I previously had assumed string representation to be always the same as .toString() but I was wondering if you'd consider accepting a change that would keep the current behaviour for .toString() but changes it for a console print, similar to what Chrome does:
which I am assuming would be what Deno.inspect would do as well.
The text was updated successfully, but these errors were encountered:
I just used
fetch-blob
in one of my projects and I noticed in snapshot tests that the string representation of theFile
class here is simplified in contrast to the native one:It seems to be deliberate, as there is a test covering it:
fetch-blob/test/own-misc-test.js
Lines 111 to 114 in a1a182e
The way the snapshot tests representations are constructed are not from
.toString()
but from what is usually printed in the console: https://github.com/denoland/std/blob/b213d54732282e3f635fd7e3535348b3af92e4c2/testing/snapshot.ts#L215-L226I am not completely sure yet, where to start, as I previously had assumed string representation to be always the same as
.toString()
but I was wondering if you'd consider accepting a change that would keep the current behaviour for.toString()
but changes it for a console print, similar to what Chrome does:which I am assuming would be what
Deno.inspect
would do as well.The text was updated successfully, but these errors were encountered: