Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the program/@source attribute must not contain absolute path #3811

Closed
yegor256 opened this issue Jan 13, 2025 · 0 comments · Fixed by #3883
Closed

the program/@source attribute must not contain absolute path #3811

yegor256 opened this issue Jan 13, 2025 · 0 comments · Fixed by #3883
Labels
bug good first issue help wanted

Comments

@yegor256
Copy link
Member

Currently, the program/@source attribute contains absolute path of the .eo file parsed. This is a potential security leakage, since this data exposes internal information about the environment. Instead, let's put there relative path of the file, starting from the current directory, where parser was running.
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Feb 3, 2025
@maxonfjvipon
bug(objectionary#3811): relative path
0ed8ed9
@maxonfjvipon maxonfjvipon mentioned this issue Feb 3, 2025
Merged
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Feb 4, 2025
@maxonfjvipon
bug(objectionary#3811): os
3ab3419
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Feb 4, 2025
@maxonfjvipon
Merge branch 'master' into bug/objectionary#3811/relative-source-path
a1cfe89
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Feb 4, 2025
@maxonfjvipon
bug(objectionary#3811): visibility
b130186
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Feb 4, 2025
@maxonfjvipon
bug(objectionary#3811): dependency
705756c
github-merge-queue bot pushed a commit that referenced this issue Feb 4, 2025
@yegor256
Merge pull request #3883 from maxonfjvipon/bug/#3811/relative-source-…
e3cc5ec 
…path

bug(#3811): relative `/program/@source` path
@maxonfjvipon maxonfjvipon mentioned this issue Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug(#3811): relative /program/@source path maxonfjvipon/eo
1 participant
@yegor256