Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Snapshots #12

Closed
maennchen opened this issue Apr 18, 2020 · 11 comments · May be fixed by #47
Closed

Add Support for Snapshots #12

maennchen opened this issue Apr 18, 2020 · 11 comments · May be fixed by #47
Assignees
Labels
enhancement New feature or request

Comments

@maennchen
Copy link
Collaborator

https://kubernetes-csi.github.io/docs/external-snapshotter.html

@maennchen maennchen added enhancement New feature or request help wanted Extra attention is needed labels Apr 21, 2020
@maennchen
Copy link
Collaborator Author

For both snapshots & volume content source, files have to be synced via gsutil rsync (please mention better ideas :) )

I would recommend that CreateSnapshot and also the restoring of a snapshot / from another volume (#13) starts a Job with a gsutil container that actually does the copying. The function would block until the call succeeded.

@ofek
Copy link
Owner

ofek commented Apr 28, 2020

@maennchen
Copy link
Collaborator Author

@ofek One at a time, yes....

@ofek
Copy link
Owner

ofek commented Apr 28, 2020

Should we include gsutil even though it would be large? I'm not a k8s expert but starting a job seems hacky. Is it?

@maennchen
Copy link
Collaborator Author

@ofek I don't think that this would be hacky... I think that's a perfect application of K8S.

I would create a separate image only doing that and not package it into the same container.

@ofek
Copy link
Owner

ofek commented Apr 28, 2020

I mean, is it normal for a container to start another container?

@maennchen
Copy link
Collaborator Author

For Operators: yes

@ofek
Copy link
Owner

ofek commented Apr 28, 2020

Hmm interesting, okay then 😄

@maennchen
Copy link
Collaborator Author

Better Idea:

Instead of waiting minutes to copy small amounts of data via gsutil, a TransferJob can be created & executed via API. This should be fairly fast and needs no compute power.

https://cloud.google.com/storage-transfer/docs/reference/rest/v1/transferJobs/create

Credit @jeremyzahner

@ofek
Copy link
Owner

ofek commented May 5, 2020

Oh very neat. We'd just need to document how to add the required scope to a service account.

@maennchen maennchen self-assigned this May 5, 2020
@maennchen maennchen removed the help wanted Extra attention is needed label May 5, 2020
@maennchen
Copy link
Collaborator Author

Tracked via #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants