Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiverhelper] Implement new component-identifying attributes #12117

Open
jade-guiton-dd opened this issue Jan 17, 2025 · 0 comments
Open

[receiverhelper] Implement new component-identifying attributes #12117

jade-guiton-dd opened this issue Jan 17, 2025 · 0 comments
Labels
area:receiver enhancement New feature or request

Comments

@jade-guiton-dd
Copy link
Contributor

jade-guiton-dd commented Jan 17, 2025

The new Pipeline Component Telemetry RFC defines a set of attributes that should be used to describe which component instance a telemetry item comes from.

At the moment, the receiverhelper emits the receiver's component ID as a receiver attribute on metrics and as part of the span name for traces. To bring this in line with the RFC, we would need to add the following attributes to metrics and spans:

  • otelcol.component.kind: always receiver
  • otelcol.component.id: the component ID
  • otelcol.signal: logs, metrics, traces, profiles

(As mentioned in the RFC, otelcol.signal is not mandatory for singleton receivers, but adding it in all cases should be fine.)

All this information should already be available in the helper, but instead of implementing the attributes manually, I would recommend waiting to see if the pipeline telemetry implementation introduces a general mechanism for getting these attributes.

This would be a step towards the stabilization of the otlpreceiver: cf. #11139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:receiver enhancement New feature or request
Projects
Status: Blocked
Development

No branches or pull requests

2 participants