Fix declarative configuration in javaagent example #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
commented
Oct 18, 2024
| @@ -3,4 +3,4 @@ FROM eclipse-temurin:11-jre | |||
| ADD build/libs/app.jar /app.jar | |||
| ADD build/agent/opentelemetry-javaagent.jar /opentelemetry-javaagent.jar | |||
|
|
|||
| ENTRYPOINT java -jar -javaagent:/opentelemetry-javaagent.jar /app.jar | |||
| ENTRYPOINT java -javaagent:/opentelemetry-javaagent.jar -jar /app.jar | |||
There was a problem hiding this comment.
the -jar -javaagent ordering was causing a manifest error trying to load the jar
jaydeluca
force-pushed
the
fix-declarative-config
branch
from
447c64c to
579ab02
Compare
jaydeluca
commented
Oct 18, 2024
| @@ -8,14 +8,14 @@ services: | |||
| # Logs are disabled by default | |||
| OTEL_LOGS_EXPORTER: "otlp" | |||
| # Optional specify file configuration instead of using environment variable scheme | |||
| # To use, call "export OTEL_CONFIG_FILE=/sdk-config.yaml" before calling docker compose up | |||
| OTEL_CONFIG_FILE: | |||
| OTEL_EXPERIMENTAL_CONFIG_FILE: /sdk-config.yaml | |||
There was a problem hiding this comment.
i figured this behavior could be the default in the example, but I can return it to being optional if we want
|
oops i dont know how i didnt notice the other PR 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.