Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Spec Deprecations & Migration #1696

Open
snowman2 opened this issue Jan 14, 2025 · 1 comment
Open

Grid Spec Deprecations & Migration #1696

snowman2 opened this issue Jan 14, 2025 · 1 comment

Comments

@snowman2
Copy link
Contributor

snowman2 commented Jan 14, 2025

@deprecat(
reason="The Grid Workflow is deprecated. This property may return an (optional) odc-geo GridSpec in future.",
version="1.9.0",
category=ODC2DeprecationWarning
)
def grid_spec(self) -> Optional['GridSpec']:

The grid_spec method is currently deprecated meaning that a new odc-geo GridSpec class will likely be returned. Currently there is no way to opt-in to the new grid_spec behavior without overwriting the grid_spec method.

The current difference between the two classes is the tile_size | tile_shape parameter.

What are your thoughts about allowing users to opt-in to the new behavior of returning the new odc-geo GridSpec class and avoid the warnings by supplying the tile_shape parameter in the storage information instead of the tile_size parameter?

@SpacemanPaul
Copy link
Contributor

That makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants