Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles loading fail on some url sinces 2.3.10 #1910

Open
fhoshino opened this issue Feb 5, 2025 · 13 comments
Open

Styles loading fail on some url sinces 2.3.10 #1910

fhoshino opened this issue Feb 5, 2025 · 13 comments
Labels

Comments

@fhoshino
Copy link

fhoshino commented Feb 5, 2025

Description

On some url, usually telegram web chat, some styles failed to load, especially those for font changing.
Not only telegram web, but also in some random websites.
Even reloading a page and cycling disable/enable of the styles will not work.

Currently I'm loading 2.3.9 unpacked to mitigate this issue.

System Information

  • OS: Windows 10 x64
  • Browser: Brave Version 1.75.173 Chromium: 133.0.6943.39 (Official Build) (64-bit)
  • Stylus Version: 2.3.10

Screenshots, links, CSS

@fhoshino fhoshino added the bug label Feb 5, 2025
@tophf
Copy link
Member

tophf commented Feb 5, 2025

  1. I can't fix something I don't see myself, i.e. I need to install the style you're using and repeat the actions you were doing.
  2. AFAICT there are no changes in source code for style matching between 2.3.9 and 2.3.10.

@tophf
Copy link
Member

tophf commented Feb 5, 2025

I wonder if style cache database got corrupted. Try clicking Reload in the right-click menu for the extension's icon in the browser's toolbar.

@fhoshino
Copy link
Author

fhoshino commented Feb 5, 2025

Ok, I tried to backup, uninstall and reinstall the extension then import my backup
Seems the issue is gone for now. Maybe you are correct, the cache database is corrupted.

@Ultrabenosaurus
Copy link

I am seeing no matches at all for any styles against any websites in Fennec F-Droid on Android since I got this update today. I also can't actually open the Stylus settings / Manage page as most of the UI elements do nothing, so I can't backup or export my styles to reinstall the addon.

2. AFAICT there are no changes in source code for style matching between 2.3.9 and 2.3.10.

Looking at the version history on the Mozilla website, it jumped from 1.5.51 straight to 2.3.10 so there being no changes to style matching code since 2.3.9 doesn't really matter.

https://addons.mozilla.org/en-GB/firefox/addon/styl-us/versions/

I've used Stylus on Android for years and years, starting in the old version of the Android browser and then in Fennec F-Droid ever since they added addon support to the new codebase a few years ago.

@tophf
Copy link
Member

tophf commented Feb 6, 2025

@Ultrabenosaurus, the Firefox version's problems you've described are not related to this particular issue. Please open a new issue.

@fhoshino
Copy link
Author

fhoshino commented Feb 6, 2025

@Ultrabenosaurus
reinstall 1.5.51 here: https://github.com/openstyles/stylus/releases/download/v1.5.51/styl_us-1.5.50.xpi
export your styles,
uninstall it, get the new version from moz addon, import the file.

@tophf
Copy link
Member

tophf commented Feb 6, 2025

Looks like no one has ever tested the 2.x version in Firefox for Android and it turns out there's no support for some permissions that Firefox for desktops supports like contextMenus. I'll ask @Mottie to revert the extension in AMO until we post a fixed version. Meanwhile you can install the older version manually as suggested above (I don't know if there's a simpler method).

@Ultrabenosaurus
Copy link

@Ultrabenosaurus reinstall 1.5.51 here: https://github.com/openstyles/stylus/releases/download/v1.5.51/styl_us-1.5.50.xpi export your styles, uninstall it, get the new version from moz addon, import the file.

Thank you for the suggestion, but unfortunately it's not a case of simply downloading and installing the xpi file, at least not on Android.

@BlaisePx
Copy link

BlaisePx commented Feb 7, 2025

@Ultrabenosaurus reinstall 1.5.51 here: https://github.com/openstyles/stylus/releases/download/v1.5.51/styl_us-1.5.50.xpi export your styles, uninstall it, get the new version from moz addon, import the file.

How does one do this on Android when the xpi file cannot be used by Firefox?

@enter-a-random-username

This comment has been minimized.

@Ghis1964
Copy link

"styles not loading"
This happens on no matter the site/page. These styles and pages/sites always worked before. I can be on google/youtube/twitter/you-name-it and clone/open a tab and the style can load or not.

To say it's a bug in Stylus would be outlandish. This happens even if I down-grade 5 or 10 versions down now. I'd rather blame Firefox for that, but the only true way to verify would be to down-grade firefox to some ESR version which I won't do.

Hope this help.

@JamieBlu
Copy link

I'm using 2.3.10 in FF 135.0 on a firewalled page at https://REDACTED.brightspace.com/d2l/le/calendar/364686/event/1206996/detailsview#1206996. The extension does not seem to see the page at all as it says "no styles installed for this site". Until today it had been working perfectly for years.

@Saxayone
Copy link

Yeah, ever since the 2.3.10 update on firefox desktop I'm constantly running into random styles not loading until I manually uncheck>recheck them in a session.
They work fine for that site for the rest of the session but fail again if firefox is closed and re-open again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants