Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manager] share order catalog typings #13847

Open
1 task done
tristanwagner opened this issue Oct 30, 2024 · 1 comment
Open
1 task done

[manager] share order catalog typings #13847

tristanwagner opened this issue Oct 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tristanwagner
Copy link
Contributor

tristanwagner commented Oct 30, 2024

Have you already contact our help centre?

  • Yes, I have contact the help centre.

Describe the problem

I need to use the order catalog for a specific product, I can see that all the typing of the API response has already been done in another project, I think it might be useful to share these types across projects.

Here is the API route I'm talking about GET /order/catalog/public/{productName}

This could be applied to all API typing for routes that are commonly used across multiple projects.

Describe the solution

Here is the file that I could reuse for Order Catalog typing.

While this typing is very well made, I would like to add a nitpick on the enums, to me the enum content should always be uppercased like this

  // no
  export enum TestEnum {
   'something' = 'something',
  }

  // yes
  export enum TestEnum {
   SOMETHING = 'something',
  }

Describe alternatives you've considered

No response

Additional context

No response

@tristanwagner tristanwagner added the enhancement New feature or request label Oct 30, 2024
@tristanwagner
Copy link
Contributor Author

as discussed it would be nice to have all public apis typings available in manager-core-api, and it might be possible to generate them automatically from some swagger files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant