Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase out payload conversion helpers #14072

Open
mattsse opened this issue Jan 29, 2025 · 1 comment · May be fixed by #14090
Open

Phase out payload conversion helpers #14072

mattsse opened this issue Jan 29, 2025 · 1 comment · May be fixed by #14090
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes
Milestone
Release 1.2.0

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 29, 2025

Describe the feature

all of those can be removed after the next alloy bump because these are natively supported

reth/crates/rpc/rpc-types-compat/src/engine/payload.rs

Line 17 in 6d55149

pub fn block_to_payload<T: SignedTransaction>(

TODO

  • remove fns and replace with new Payload::from fns

blocked

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes labels Jan 29, 2025
@mattsse mattsse added this to the Release 1.2.0 milestone Jan 29, 2025
@hoank101
Copy link
Contributor

hi, i can do it

@hoank101 hoank101 linked a pull request Jan 30, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes
Projects
Reth Tracker
Status: Todo
Milestone
Release 1.2.0
Development

Successfully merging a pull request may close this issue.

feat: phase out payload conversion helpers hoank101/reth
2 participants
@mattsse @hoank101