Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a Playground’s bindings signals MessageNotUnderstood #17803

Open
Rinzwind opened this issue Feb 9, 2025 · 5 comments
Open

Opening a Playground’s bindings signals MessageNotUnderstood #17803

Rinzwind opened this issue Feb 9, 2025 · 5 comments

Comments

@Rinzwind
Copy link
Contributor

Rinzwind commented Feb 9, 2025

In Pharo 13 build 504, after doing n := 1 in a Playground, opening its bindings signals a MessageNotUnderstood (“Instance of SmallInteger did not understand #windowTitle”).

@Rinzwind
Copy link
Contributor Author

Rinzwind commented Feb 9, 2025

I checked earlier builds: a MessageNotUnderstood is signaled in build 465, but not in build 464. The reference commits for these builds are given below (listed using the snippet given in issue #17163). This issue seems most likely to be due to the changes in Spec commit 8c6e6f0291 or NewTools commit 612a06e542 by @Ducasse.

Build 465 reference commits:

pharo: 3ef74fbea6be30a175ee015e2f227401f80c18b5
Spec2: 8c6e6f0291347b3323255e9af4efda311693a632
NewTools: 612a06e542fe6a410590bb312be3fede655c9e79
Roassal: 613f15ca24aa4416d86eb7754bb74d78193df1da
Microdown: 7b740f2c90d2ae5f2c5d9dcb44abba46a4d8d0ce
tonel: 04f7d5416aa82b9893b37cb0aa3ceab24f82f745

Build 464 reference commits;

pharo: 583b850b90f166cb920dee5fc3fe9994dd3a499e
Spec2: 9bd929c51251bfccd61f61a9a312a581f34508f7
NewTools: d85e31bdf365139e542944ed160b24309c66af23
Roassal: 613f15ca24aa4416d86eb7754bb74d78193df1da
Microdown: 7b740f2c90d2ae5f2c5d9dcb44abba46a4d8d0ce
tonel: 04f7d5416aa82b9893b37cb0aa3ceab24f82f745

@Ducasse
Copy link
Member

Ducasse commented Feb 10, 2025

Oops it should probably be my mistake. I will have a look

@Ducasse
Copy link
Member

Ducasse commented Feb 10, 2025

Probably

StInspectorPresenter >> windowTitle
	^ self model windowTitle
	
	^ self model ifNotNil: [ :m | m windowTitle ] ifNil: [ 'Inspector']

Now I put

StInspectorPresenter >> windowTitle
	
	^ self model ifNotNil: [ :m | m printString ] ifNil: [ 'Inspector']

and it seems to work.
Having title on SmallInteger did not make that much sense to me.

@Ducasse Ducasse closed this as completed Feb 10, 2025
@Ducasse Ducasse reopened this Feb 10, 2025
@Ducasse
Copy link
Member

Ducasse commented Feb 10, 2025

pharo-spec/NewTools#991

@Rinzwind
Copy link
Contributor Author

OK, but now the window title when inspecting String loremIpsum is (build 511):

Whereas before it was (build 506):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants