Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate where tophat gem features are used #3052

Open
corylown opened this issue Jul 9, 2024 · 2 comments · May be fixed by #3253
Open

Investigate where tophat gem features are used #3052

corylown opened this issue Jul 9, 2024 · 2 comments · May be fixed by #3253
Assignees

Comments

@corylown
Copy link
Contributor

corylown commented Jul 9, 2024

Gem hasn't been updated in 7 years :https://github.com/stve/tophat
Can we remove it or replace it?

@corylown corylown self-assigned this Jul 15, 2024
@corylown
Copy link
Contributor Author

Looks like we're using this to add twitter and opengraph metatags, like:

<meta name="description" content="Martin Wong Catalogue Raisonné (MWCR) is an online, comprehensive compilation of finished artworks by Martin Wong." />
<meta name="twitter:card" value="summary" />
<meta name="twitter:url" value="https://exhibits.stanford.edu/martin-wong" />
<meta name="twitter:title" value="Martin Wong Catalogue Raisonné" />
<meta name="twitter:description" value="From the Martin Wong Foundation" />
<meta name="twitter:image" value="/images/9306-2a1cb57782fefab503b3d169328f869b/0,0,1012,1012/400,400/0/default.jpg" />

<meta property="og:title" content="Martin Wong Catalogue Raisonné" />
<meta property="og:image" content="/images/9306-2a1cb57782fefab503b3d169328f869b/0,0,1012,1012/400,400/0/default.jpg" />
<meta property="og:site_name" content="Spotlight at Stanford" />

Added in this commit: fd111fd

Last release of the gem was in 2017: https://rubygems.org/gems/tophat/versions/2.3.1?locale=en

We're using this gem in a few other projects as well:

  • purl
  • library_hours_rails
  • mise

@corylown corylown removed their assignment Sep 4, 2024
@dnoneill
Copy link
Contributor

dnoneill commented Nov 1, 2024

@corylown I am looking into this as part of sul-dlss/exhibits#2497. TopHat is malforming data. meta tags are supposed to have content="url/description/whatever the tag is". TopHat is putting it in value which is malforming. I am going to go ahead and start looking at how we might be able to replace this.

@dnoneill dnoneill self-assigned this Nov 1, 2024
@dnoneill dnoneill linked a pull request Nov 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants