Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# fmt: skip doesn't work with multiline strings #4513

Open
MeGaGiGaGon opened this issue Nov 15, 2024 · 4 comments
Open

# fmt: skip doesn't work with multiline strings #4513

MeGaGiGaGon opened this issue Nov 15, 2024 · 4 comments
Labels
F: strings Related to our handling of strings T: bug Something isn't working

Comments

@MeGaGiGaGon
Copy link
Collaborator

MeGaGiGaGon commented Nov 15, 2024

I found this while messing around with #4511

playground link

(
# fmt: skip
"""
"""
)

gives
Cannot parse: 2:0: EOF in multi-line string

playground link

(
# fmt: skip
"\
"
)

gives
Cannot parse: 2:0: "


This is not fixed by #4380


This is fixed by #3978, though that PR appears to be stalled.
With #3978 applied:

(
# fmt: skip
"""
"""
)

gives

(
    # fmt: skip
    """
"""
)
(
# fmt: skip
"\
"
)

gives

(
    # fmt: skip
    ""
)
@MeGaGiGaGon MeGaGiGaGon added the T: bug Something isn't working label Nov 15, 2024
@JelleZijlstra JelleZijlstra added the F: strings Related to our handling of strings label Nov 15, 2024
@Student-ShivamChauhan
Copy link

please assign me this issue i want to work on it ☺️

@Student-ShivamChauhan
Copy link

check my pull request and merge, it's my first contribution in gsoc, and i am happy for do this open source work

@MeGaGiGaGon
Copy link
Collaborator Author

@Student-ShivamChauhan I've unassigned you since I've just confirmed that's not really a thing in this project, but feel free to open a fixing PR on any issue regardless of if you are assigned or not :)

@Student-ShivamChauhan
Copy link

please give me hint what i can change to improve this repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: strings Related to our handling of strings T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants