Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load FontAwesome script at end of body #2116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaycebasques
Copy link
Contributor

Fixes #2115

@trallard
Copy link
Collaborator

trallard commented Jan 31, 2025

Unfortunately, this reverts back some changes made in #1982 that had to be made as an Uncaught ReferenceError: FontAwesome is not defined error appears, which prevents custom icons from being added (see screenshot where these are missing from our navbar)

Cursor_and_The_PyData_Sphinx_Theme_—_PyData_Theme_0_16_1_documentation

There are for sure improvements needed on how we handle FA, which also result in what you see in #2115, so merging this PR would directly impact any users adding custom icons to their documentation, so I would prefer not merging this PR and instead going back and properly fix the FA vendoring (using SVG only vs the current SVG + webfont approach, but that would also need extra work on components like admonitions and what not to ensure proper rendering), I just have not had enough bandwidth to focus on that larger piece of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make FontAwesome script less render-blocking
2 participants