Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2025.01.2 #10002

Open
kmuehlbauer opened this issue Jan 29, 2025 · 6 comments · May be fixed by #10007
Open

Release 2025.01.2 #10002

kmuehlbauer opened this issue Jan 29, 2025 · 6 comments · May be fixed by #10007
Labels
Release Planning and tracking progress of releases

Comments

@kmuehlbauer
Copy link
Contributor

kmuehlbauer commented Jan 29, 2025

What is your issue?

This issue tracks the release for allowing non-nanosecond datetimes/timedeltas (adapting to pandas) behaviour. We aimed for a release in January, so there quite some references to that release in the codebase/docs.

Must have:

Nice to have:

I'll start preparing release tomorrow. @pydata/xarray please add items as needed. Also raise concerns about the release date, if there are any.

@kmuehlbauer kmuehlbauer added needs triage Issue that has not been reviewed by xarray team member Release Planning and tracking progress of releases and removed needs triage Issue that has not been reviewed by xarray team member labels Jan 29, 2025
@dcherian
Copy link
Contributor

@aulemahal @Zeitsperre can you confirm that the xclim test suite is not failing after our switch to support non-nanosecond datetimes please?

@Zeitsperre
Copy link
Contributor

@dcherian Thanks for checking in with us. We've been busy at a corporate conference our company held the past few days, but we'll give things a look today.

Right off the bat, our upstream xarray tests seem to be failing: Ouranosinc/xclim#2062

@kmuehlbauer
Copy link
Contributor Author

kmuehlbauer commented Jan 30, 2025

@Zeitsperre The last run shows green, not? https://github.com/Ouranosinc/xclim/actions/workflows/upstream.yml

Update: There has been some groupby/flox changes in the last days which have been reverted yesterday IIRC. Good chance that this was the reason of the intermittent failing of your upstream CI. But anyway, please doublecheck, I do not want to release something which is known to break downstream. Thanks!

@aulemahal
Copy link
Contributor

I confirm that the current main of xarray does not break xclim's test suite! It seems indeed, that the breaking two days ago was temporary.

@dcherian
Copy link
Contributor

Amazing, thanks!

@kmuehlbauer
Copy link
Contributor Author

@pydata/xarray All issues have been sorted out, no release blocker anymore. Thanks all 💯!

I've updated #10007. So this seems ready to fly. I've set the release date to January 31, so I'm going to get the release out tomorrow morning. If there are any last minute changes which should go in, please add these to the list above until January 31, 7 UTC. I'm about to release at 8-9 UTC, January 31. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Planning and tracking progress of releases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants