-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2025.01.2 #10002
Comments
@aulemahal @Zeitsperre can you confirm that the xclim test suite is not failing after our switch to support non-nanosecond datetimes please? |
@dcherian Thanks for checking in with us. We've been busy at a corporate conference our company held the past few days, but we'll give things a look today. Right off the bat, our upstream xarray tests seem to be failing: Ouranosinc/xclim#2062 |
@Zeitsperre The last run shows green, not? https://github.com/Ouranosinc/xclim/actions/workflows/upstream.yml Update: There has been some groupby/flox changes in the last days which have been reverted yesterday IIRC. Good chance that this was the reason of the intermittent failing of your upstream CI. But anyway, please doublecheck, I do not want to release something which is known to break downstream. Thanks! |
I confirm that the current main of xarray does not break xclim's test suite! It seems indeed, that the breaking two days ago was temporary. |
Amazing, thanks! |
@pydata/xarray All issues have been sorted out, no release blocker anymore. Thanks all 💯! I've updated #10007. So this seems ready to fly. I've set the release date to January 31, so I'm going to get the release out tomorrow morning. If there are any last minute changes which should go in, please add these to the list above until January 31, 7 UTC. I'm about to release at 8-9 UTC, January 31. Thanks |
What is your issue?
This issue tracks the release for allowing non-nanosecond datetimes/timedeltas (adapting to pandas) behaviour. We aimed for a release in January, so there quite some references to that release in the codebase/docs.
Must have:
CFTimedeltaCoder
todecode_timedelta
#9966freq="D"
instead offreq="d"
inpd.timedelta_range
#10004numpy
scalars to arrays inNamedArray.from_array
#10008Nice to have:
I'll start preparing release tomorrow. @pydata/xarray please add items as needed. Also raise concerns about the release date, if there are any.
The text was updated successfully, but these errors were encountered: