Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be a smidge more error tolerant? #1003

Open
thejcannon opened this issue Jan 18, 2024 · 2 comments · May be fixed by #1004
Open

Be a smidge more error tolerant? #1003

thejcannon opened this issue Jan 18, 2024 · 2 comments · May be fixed by #1004

Comments

@thejcannon
Copy link
Contributor

While playing around with using setuptools_scm I hit more than a few AssertionErrors with the only context being the code and traceback.

Perhaps these could be improved with an assertion message, or even a ValueError instead 😄
@RonnyPfannschmidt
Copy link
Contributor

Absolutely

@thejcannon
Copy link
Contributor Author

FYI I'll re-create those situations and bake you a perfectly crisp PR 🧑‍🍳

@thejcannon thejcannon linked a pull request Jan 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Be nicer about possible misconfigurations thejcannon/setuptools_scm
2 participants
@RonnyPfannschmidt @thejcannon