Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoconf: Sync config.guess, config.sub with CPython repo, update to latest #36

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

autoconf: Sync config.guess, config.sub with CPython repo, update to latest #36

wants to merge 3 commits into from

Conversation

rhansen
Copy link
Contributor

@rhansen rhansen commented Dec 4, 2024

config.sub.patch is derived from: python/cpython@bee7bb3

erlend-aasland
erlend-aasland reviewed Jan 2, 2025
View reviewed changes
autoconf/config.sub.patch Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably try to upstream this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted a patch upstream: https://lists.gnu.org/archive/html/config-patches/2025-01/msg00000.html
After I did that, @freakboy3742 let me know that he had attempted to upstream the change a couple of times without success: https://lists.gnu.org/archive/html/config-patches/2025-01/msg00001.html. Maybe third time's the charm?

autoconf/Dockerfile Outdated
Comment on lines 8 to 9
ARG CONFIG_GUESS_REV="9428e344e65176b03b69e4bf4ed0d0fc51d4c26f"
ARG CONFIG_SUB_REV="948ae97ca5703224bd3eada06b7a69f40dd15a02"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit 9428e344e is from 2021-10-18, and 948ae97ca is from 2024-01-01. We should consider using a more recent rev for both of these files. We consider also to just use a common config.git rev; I guess we usually want config.guess and config.sub to be sync'ed to the same config.git checkout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both of your points. However, I think updating them should be done in a future PR because changing either config.guess or config.sub requires coordination with the cpython repo. I plan on opening additional pull requests to both cpython and this repo once this PR is merged.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, we can safely do so in this PR and make a release. The CPython repo is not affected until we explicitly change the CI and regen-configure script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated config.guess and config.sub to the latest revision in the config.git repo.

Please do not squash this PR's commits when merging (doing so will make it more difficult to understand the history if needed to troubleshoot a problem).

@erlend-aasland erlend-aasland linked an issue Jan 2, 2025 that may be closed by this pull request
Autoconf: Also provide config.guess and config.sub #32
Open
erlend-aasland
erlend-aasland reviewed Jan 7, 2025
View reviewed changes
autoconf/Dockerfile Outdated Show resolved Hide resolved
@rhansen rhansen changed the title autoconf: Sync config.guess, config.sub with CPython repo autoconf: Sync config.guess, config.sub with CPython repo, update to latest Jan 7, 2025
erlend-aasland
erlend-aasland approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your continued improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autoconf: Also provide config.guess and config.sub
2 participants
@rhansen @erlend-aasland