Fix "not callable" issue for @dataclass(frozen=True) with Final attr
#18572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
JukkaL
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Hmm what about changing _freeze in mypy.plugins.dataclasses to skip final attributes? Does it turn final attributes into properties? If yes, this sounds wrong to me.
Can you also test what happens if you access a final attribute via the type object, e.g. My.a?
Yes, it does. I will check what can be done there! |
|
@JukkaL you were right, |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18567
We should allow inferenced
a: Final = 1