Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOP icon is grey instead of orange #21734

Open
nokti opened this issue Nov 1, 2024 · 26 comments · May be fixed by #21749
Open

STOP icon is grey instead of orange #21734

nokti opened this issue Nov 1, 2024 · 26 comments · May be fixed by #21749
Labels
Look and feel Affect UI "Look and feel" only without changing the logic

Comments

@nokti
Copy link

nokti commented Nov 1, 2024

qBittorrent & operating system versions

qBit v5.0.1 lt 2.0.11 qt 6.7.3
Win 10 Pro x64 22H2 19045.5073

What is the problem?

The stop icon in the left side column is grey when it should be orange like on top I suppose.

image

Steps to reproduce

Launch qBit

Additional context

This happens whether dark mode is on or off (I disabled it through qt.conf).

Log(s) & preferences file(s)

qBittorrent.txt

@stalkerok
Copy link
Contributor

Related discussion #20532 (comment)
@glassez @Chocobo1 @xavier2k6 @thalieht Anyone against making the icon orange?

@thalieht thalieht added the Look and feel Affect UI "Look and feel" only without changing the logic label Nov 1, 2024
@ionGL
Copy link

ionGL commented Nov 1, 2024

Just manually change the "stopped" icon with the orange one if you want.
https://github.com/qbittorrent/qBittorrent/blob/master/src/icons/torrent-stop.svg

Or you can change the top "torrent-stop" icon to gray.
https://github.com/qbittorrent/qBittorrent/blob/master/src/icons/stopped.svg

@glassez
Copy link
Member

glassez commented Nov 2, 2024

Or you can change the top "torrent-stop" icon to gray.
https://github.com/qbittorrent/qBittorrent/blob/master/src/icons/stopped.svg

👎

@nokti
Copy link
Author

nokti commented Nov 2, 2024

Just manually change the "stopped" icon with the orange one if you want. https://github.com/qbittorrent/qBittorrent/blob/master/src/icons/torrent-stop.svg

I'd love to do that but where do I place this icon? There's no folder with the qBit icons.

@stalkerok
Copy link
Contributor

2024-11-02_121151

@glassez
Copy link
Member

glassez commented Nov 2, 2024

Related discussion #20532 (comment)
@glassez @Chocobo1 @xavier2k6 @thalieht Anyone against making the icon orange?

I don't care. The main thing is that it should not be gray in the toolbox and context menu, where it may look confusing (like a disabled/unavailable item).

@xavier2k6
Copy link
Member

Changing that icon to orange will then not match the corresponding text color in transfer list & there's already issues there......

@stalkerok
Copy link
Contributor

I would change not only the icon, but also the text.

@stalkerok stalkerok linked a pull request Nov 2, 2024 that will close this issue
@Pentaphon
Copy link

I would change not only the icon, but also the text.

If you do this, you will get people complaining about their torrent list being full of orange text since a lot of people keep torrents in their stopped state.

The list should be mostly black text and the color should only change when something is happening to a torrent like:

red = error
orange = stalled
green = uploading data to peers
blue = downloading data from peers

#21448 is my outline of how the text colors should be and I think many people agree with it.

@sledgehammer999
Copy link
Member

I propose treating the grey-icon as an intended differentiation. Aka non a bug.

@Pentaphon
Copy link

I propose treating the grey-icon as an intended differentiation. Aka non a bug.

I think the stop icon should be more recognizable as a stop icon, yet simple, like this.

3167008

@stalkerok
Copy link
Contributor

stalkerok commented Nov 3, 2024

Ok. Does anyone have any suggestions for a uniform color for the stop icon?

@ArcticGems
Copy link

I wonder if there is a good choice, even the creator of current icons said in hindsight that it would be best with 2 icon sets since it's hard to make it work for both light and dark mode.

@Pentaphon
Copy link

Ok. Does anyone have any suggestions for a uniform color for the stop icon?

If we want to keep it simple, it should be a simple red square or....a simple red octagon like so

oct

@stalkerok
Copy link
Contributor

Red is reserved for critical errors, it's definitely not appropriate here.

@Pentaphon
Copy link

LOL I just wanted my square to be orange, now I've got it and I'm happy. I'd rather the devs spent their time on more critical issues than this.

I'm fine with the orange square if the devs are ok with it. I just thought making the text orange as well was going too far.

@Pentaphon
Copy link

Red is reserved for critical errors, it's definitely not appropriate here.

How about a simple black circle with a white square inside it?

120632

@nokti
Copy link
Author

nokti commented Nov 3, 2024

LOL I just wanted my square to be orange, now I've got it and I'm happy. I'd rather the devs spent their time on more critical issues than this.

@nokti
Copy link
Author

nokti commented Nov 3, 2024

I'm fine with the orange square if the devs are ok with it. I just thought making the text orange as well was going too far.

Text color should only change when a torrent is actively moving data or must be looked at.

I agree with you on that. I was half-joking anyway (although it's true that ressources are limited and should be focused on more important issues).

@sledgehammer999
Copy link
Member

I am inclined to close this as wontfix.
Why?
I just realized that in v5.0.x users can changed both colors and icons of the GUI.
Just go to Tools->Options...->Behavior->Customize UI Theme... and theme the app any way you see fit for your tastes.

@ionGL
Copy link

ionGL commented Nov 3, 2024

I just realized that in v5.0.x users can changed both colors and icons of the GUI. Just go to Tools->Options...->Behavior->Customize UI Theme... and theme the app any way you see fit for your tastes.

The op didn't realize this either. When users have the option to change all icons and colors as they like, it's a waste of time to argue what the default ones should be at this point.

It would be nice if changing icons and colors would be applied on the fly, without reopening the program.

@Pentaphon
Copy link

Just go to Tools->Options...->Behavior->Customize UI Theme... and theme the app any way you see fit for your tastes.

I agree this is a solution, but we also do need to come up with better default colors and icons so we don't have so many people have to switch things around every time they install qBittorrent. We should still pursue a "2.0 version" of the light and dark themes.

@stalkerok
Copy link
Contributor

@sledgehammer999 Why can't we make it a single color by default? Okay, gray isn't suitable. Why can't it be orange? I'm not suggesting this color particularly, but we can make the default icon (+text) a single color. And then users can change it to whatever they want.

@sledgehammer999
Copy link
Member

Why can't we make it a single color by default?

Do you mean same color for all states? Well, no. Traditionally we use different colors per state and switching to monochromatic would be a huge downgrade in UX.

@stalkerok
Copy link
Contributor

Do you mean same color for all states?

For a stop state!

@Pentaphon
Copy link

Pentaphon commented Nov 4, 2024

Why can't we make it a single color by default? Okay, gray isn't suitable. Why can't it be orange? I'm not suggesting this color particularly, but we can make the default icon (+text) a single color. And then users can change it to whatever they want.

Nobody can agree on another color and people don't seem to like black/grey icons. We need to wait for somebody to fix all the icons on both dark and light themes so they all match well together and the community approves of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Look and feel Affect UI "Look and feel" only without changing the logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants