Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old version of code example in the docs #2152

Open
kota-yata opened this issue Feb 11, 2025 · 2 comments
Open

Old version of code example in the docs #2152

kota-yata opened this issue Feb 11, 2025 · 2 comments

Comments

@kota-yata
Copy link

I was looking at the certificate example at the quinn docs and realized it was not up to date.

It shows that client configuration is done with following code:

fn configure_client() -> ClientConfig {
    let crypto = rustls::ClientConfig::builder()
        .with_safe_defaults()
        .with_custom_certificate_verifier(SkipServerVerification::new())
        .with_no_client_auth();

    ClientConfig::new(Arc::new(crypto))
}

but this only works before this commit, when QuicClientConfig was not yet introduced.

Other example code in the docs might be outdated too although I haven't tried them all.

@djc
Copy link
Member

djc commented Feb 11, 2025

Thanks for the report! Would you be able to submit a PR?

@kota-yata
Copy link
Author

sure! I'm working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants