Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port or remove footer.html template #464

Open
stsewd opened this issue Aug 26, 2024 · 1 comment
Open

Port or remove footer.html template #464

stsewd opened this issue Aug 26, 2024 · 1 comment
Labels
Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented Aug 26, 2024

This template is used by our footer API

https://github.com/readthedocs/readthedocs.org/blob/main/readthedocs/api/v2/templates/restapi/footer.html

This template doesn't really make sense to be ported, so I guess we want to remove it? But if we do, that will break our old footer_html API, which may be used for old projects for some custom stuff.

ref https://github.com/readthedocs/readthedocs-corporate/pull/1807#discussion_r1729403446

@stsewd stsewd added the Needed: design decision A core team decision is required label Aug 26, 2024
@agjohnson agjohnson added this to the Deprecation and cleanup milestone Aug 26, 2024
@humitos
Copy link
Member

humitos commented Aug 27, 2024

I think it's fine deprecating this endpoint and not porting the template. Nobody will be using it after October 7th when addons became the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

4 participants
@humitos @agjohnson @stsewd and others