From c675a56796a5863ce49f41c7af852cf40437a9b1 Mon Sep 17 00:00:00 2001 From: Patrick Arminio Date: Tue, 4 Feb 2025 08:10:06 +0000 Subject: [PATCH] Add return type to `close` functions (#3496) --- redis/client.py | 3 +-- redis/cluster.py | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/redis/client.py b/redis/client.py index a7c1364a10..4fa410c65e 100755 --- a/redis/client.py +++ b/redis/client.py @@ -550,7 +550,7 @@ def __exit__(self, exc_type, exc_value, traceback): def __del__(self): self.close() - def close(self): + def close(self) -> None: # In case a connection property does not yet exist # (due to a crash earlier in the Redis() constructor), return # immediately as there is nothing to clean-up. @@ -1551,7 +1551,6 @@ def _disconnect_raise_reset( conn.retry_on_error is None or isinstance(error, tuple(conn.retry_on_error)) is False ): - self.reset() raise error diff --git a/redis/cluster.py b/redis/cluster.py index 8718493759..2fff761f95 100644 --- a/redis/cluster.py +++ b/redis/cluster.py @@ -1227,7 +1227,7 @@ def _execute_command(self, target_node, *args, **kwargs): raise ClusterError("TTL exhausted.") - def close(self): + def close(self) -> None: try: with self._lock: if self.nodes_manager: @@ -1669,7 +1669,7 @@ def initialize(self): # If initialize was called after a MovedError, clear it self._moved_exception = None - def close(self): + def close(self) -> None: self.default_node = None for node in self.nodes_cache.values(): if node.redis_connection: