Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync-pr-commit-title messing up PR title #3829

Closed
FloEdelmann opened this issue Dec 18, 2020 · 3 comments · Fixed by #3833
Closed

sync-pr-commit-title messing up PR title #3829

FloEdelmann opened this issue Dec 18, 2020 · 3 comments · Fixed by #3833
Labels

Comments

@FloEdelmann
Copy link
Member

FloEdelmann commented Dec 18, 2020

I squashed and merged this PR without changing the commit title. Afterwards, the PR title was messed up:

grafik

The commit title is fine:

grafik

Unfortunately, I cannot remember if the feature suggested the title change before merging.

@FloEdelmann
Copy link
Member Author

It didn't happen for a similar PR: OpenLightingProject/open-fixture-library#1642

@FloEdelmann
Copy link
Member Author

FloEdelmann commented Dec 20, 2020

It happened again:

Now I am sure that it didn't suggest (or rather warn in this case 😅) to change the title before merging.

@FloEdelmann
Copy link
Member Author

FloEdelmann commented Dec 21, 2020

New insights 💡

It's caused by GitHub's new (beta) auto-merge feature:

When a PR can't be merged immediately due to failing tests or missing reviews, the .is-squashing element now contains two similar forms: One for overriding branch restrictions as an admin, and a new one to enable auto-merge once all restrictions are met.

In both, there is a commit message input with id merge_title_field.

The code in sync-pr-commit-title expects this input to exist only once and thus only operates on the first one, regardless whether it is hidden (which was the case for aforementioned PRs) or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant