Problem with "a special PR that replaces org.slf4j:slf4j-log4j12"

[nielsbasjes]

How are you running Renovate?

A Mend.io-hosted app

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

I got this Renovate update nielsbasjes/energy#343 which mentions several changes; I merged this.

At the time of merge I saw that one is a replacement of org.slf4j:slf4j-log4j12 ... however I failed to notice this replacement is NOT part of the committed changes.

Then I got nielsbasjes/energy#344 which in the message again said the org.slf4j:slf4j-log4j12 ... which I merged.

Now looking at the actual commits it is really weird because the commits show the actual changes from the previous one and still do not contain the org.slf4j:slf4j-log4j12 change.

The commit hash of both of these merge requests is identical!

And then ... I got nielsbasjes/energy#345 ... which is the same thing again.

What is going wrong here?

Logs (if relevant)

Logs

          {
            "currentValue": "2.0.16",
            "currentVersion": "2.0.16",
            "datasource": "maven",
            "depName": "org.slf4j:slf4j-log4j12",
            "depType": "test",
            "editFile": "pom.xml",
            "fileReplacePosition": 2110,
            "fixedVersion": "2.0.16",
            "homepage": "http://www.slf4j.org",
            "packageName": "org.slf4j:slf4j-log4j12",
            "registryUrl": "https://repo.maven.apache.org/maven2",
            "registryUrls": [
              "https://repo.maven.apache.org/maven2"
            ],
            "sharedVariableName": "slf4j.version",
            "sourceUrl": "https://github.com/qos-ch/slf4j",
            "versioning": "maven",
            "warnings": [],
            "updates": [
              {
                "updateType": "replacement",
                "newName": "org.slf4j:slf4j-reload4j",
                "newValue": "2.0.16",
                "branchName": "renovate/all"
              }
            ]
          }

DEBUG: branches info extended
{
  "branchesInformation": [
    {
      "branchName": "renovate/all",
      "prNo": 345,
      "prTitle": "chore(deps): replace dependency org.slf4j:slf4j-log4j12 with org.slf4j:slf4j-reload4j 2.0.16",
      "result": "done",
      "upgrades": [
        {
          "datasource": "maven",
          "depName": "org.slf4j:slf4j-log4j12",
          "displayPending": "",
          "fixedVersion": "2.0.16",
          "currentVersion": "2.0.16",
          "currentValue": "2.0.16",
          "newValue": "2.0.16",
          "packageFile": "pom.xml",
          "updateType": "replacement",
          "packageName": "org.slf4j:slf4j-log4j12"
        }
      ]
    }
  ]
}

[nielsbasjes]

Looking through the logs it seems the new name of the package is found, mentioned in the title, but never actually used in a proposed code change.

[nielsbasjes]

What I find really remarkable is that a merge request is created that

• is in reality empty.
• somehow shows the changes from the last real commit as if it has these changes.

[Churro]

The replacement update includes all needed infos but the actual values update failed, which is why renovate attempts it again (and again).

Logs that you didn't include show this:

DEBUG: Unknown value (repository=nielsbasjes/energy, branch=renovate/all)
       "content": "[content]",
       "nodeName": "groupId",
       "oldValue": "org.slf4j",
       "newValue": "org.slf4j"
DEBUG: Unknown value (repository=nielsbasjes/energy, branch=renovate/all)
       "content": "[content]",
       "nodeName": "artifactId",
       "oldValue": "slf4j-log4j12",
       "newValue": "slf4j-reload4j"

which was introduced last week with PR #32635 :

renovate/lib/modules/manager/maven/update.ts

Line 198 in f7dcb3c

logger.debug({ content, nodeName, oldValue, newValue }, 'Unknown value');

I guess this could be related to the use of maven properties 🤔

[nielsbasjes]

I simplified the reproduction further to a single pom.xml with variable.
And the merged request was auto closed.
So yes clearly related to having it in a variable.

[rarkins]

In that case I think this is an overlooked feature/capability by the original author, and it doesn't mean we need to roll back the feature completely. I've added a feature request for supporting shared variable names instead. It's even possible that this is specifically for when the shared variable name is in a parent pom

[nielsbasjes]

For my real project I'm simply going to do the replace manually.

I'm leaving the reproduction project as it is now so you can check the commits and the logs at your end.

Thanks for the great tool!

[nielsbasjes]

As stated in my original message:

Now looking at the actual commits it is really weird because the commits show the actual changes from the previous one and still do not contain the org.slf4j:slf4j-log4j12 change.

@rarkins I'm unsure if this effect is part of this problem or if this is a separate thing. I leave this to you to decide.

[rarkins]

Until/unless replacements support variable names, I don't think it's worth looking into this part

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[rarkins]

Converted to issue: #34088

[rarkins]

I attempted this package rule in an attempt to disable such replacements:

  packageRules: [{
    description: "Disable maven replacements where a shared variable name is in use",
    matchJsonata: "updateType = 'replacement' and manager = 'maven' and $exists(sharedVariableName)",
    enabled: false,
  }],

But I'm not sure if it disabled too much, and I don't have time to debug further