Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples should migrate from robotInit #120

Closed
sciencewhiz opened this issue Nov 11, 2024 · 2 comments
Closed

Examples should migrate from robotInit #120

sciencewhiz opened this issue Nov 11, 2024 · 2 comments
Labels
wontfix

Comments

@sciencewhiz
Copy link
Contributor

Problem description

wpilibsuite/allwpilib#6623 removed uses of robotInit in the WPILib examples and changed to using the robot constructor. This is to prepare for eventual deprecation robotInit. Python examples should be similarly updated.

Operating System

RoboRIO

Installed Python Packages

No response

Reproducible example code

No response
@virtuald
Copy link
Member

I'm not sure this is a great idea at the moment. The robot constructor does a bunch of things, and I think that it depends

To support this, we would need to ensure that the robot constructor is empty or does things that doesn't matter. It looks like wpilib._impl.start does the important things before creating the class. If we did robotpy/mostrobotpy#89, then we could ensure this is definitely the case.

sciencewhiz added a commit to sciencewhiz/frc-docs that referenced this issue Nov 11, 2024
@sciencewhiz
Change usage of robotInit to Robot Constructor
f664507 
Fixes wpilibsuite#2679
Supersedes wpilibsuite#2689
Does not touch RobotBuilder docs, as those are generated and need to be
updated by regenerating the code
Does not touch Python. robotpy/examples#120
sciencewhiz added a commit to sciencewhiz/frc-docs that referenced this issue Nov 11, 2024
@sciencewhiz
Change usage of robotInit to Robot Constructor
787ca4e 
Fixes wpilibsuite#2679
Supersedes wpilibsuite#2689
Does not touch RobotBuilder docs, as those are generated and need to be
updated by regenerating the code
Does not touch stacktraces article, as the code and stacktraces need to
be updated together
Does not touch Python. robotpy/examples#120
@sciencewhiz sciencewhiz mentioned this issue Nov 11, 2024
Merged
jasondaming pushed a commit to wpilibsuite/frc-docs that referenced this issue Nov 11, 2024
@sciencewhiz
Change usage of robotInit to Robot Constructor (#2841)
18f593d 
* Change usage of robotInit to Robot Constructor

Fixes #2679
Supersedes #2689
Does not touch RobotBuilder docs, as those are generated and need to be
updated by regenerating the code
Does not touch stacktraces article, as the code and stacktraces need to
be updated together
Does not touch Python. robotpy/examples#120

* Remove bad Override

* Remove additional reference
@auscompgeek
Copy link
Member

I thought the conclusion was RobotPy keeping robotInit was fine: wpilibsuite/allwpilib#6623 (comment)

@auscompgeek auscompgeek closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@auscompgeek @virtuald @sciencewhiz