Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tag names which are static class properties #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

driesva
Copy link

@driesva driesva commented Nov 24, 2023

  • Tag name is correctly resolved if tag name is a static class property
  • When "discovering" custom element definitions in HTMLElementTagNameMap, where the tag name is a static class property, the node holding the property is resolved. As such lit-analyzer no-missing-element-type-definition rule behaves correctly

Resolves #278

@driesva driesva changed the title feat: support tag names wich are static class properties feat: support tag names which are static class properties Nov 24, 2023
driesva added a commit to driesva/lit-analyzer that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can tag names be TypeScript variables?
1 participant