You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Q: How difficult would it be to use Ember.Logger.debug instead of this.debug? Have not overwritten Ember core components before, and was hoping for a bit of guidance within the context of ember-debug-logger, possibly for a PR.
My issue with this.debug is the difficulty of refactoring/adding additional functionality beyond the scope of ember-debug-logger. For example, while console logging is great for now, I know I'll want to injest JSON-formatted log files, either to a 1st-party logging end-point I create or a 3rd-party service (AWS CloudWatch, Airbrake, Rollbar, etc.)
If this.debug were wrapped in Ember.Logger.debug, I could include these additional log streams at Ember.Logger.debug without touching ember-debug-logger.
The consensus seems to be that Ember.Logger isn't really necessary anymore, since it's basically just a polyfill for console.log. It intentionally didn't get assigned an import path in the new modules API.
Q: How difficult would it be to use
Ember.Logger.debug
instead ofthis.debug
? Have not overwritten Ember core components before, and was hoping for a bit of guidance within the context ofember-debug-logger
, possibly for a PR.My issue with
this.debug
is the difficulty of refactoring/adding additional functionality beyond the scope ofember-debug-logger
. For example, while console logging is great for now, I know I'll want to injest JSON-formatted log files, either to a 1st-party logging end-point I create or a 3rd-party service (AWS CloudWatch, Airbrake, Rollbar, etc.)If
this.debug
were wrapped inEmber.Logger.debug
, I could include these additional log streams atEmber.Logger.debug
without touchingember-debug-logger
.There is precedent in the community. For example,
ember-cli-rollbar
rollbar.critical(msg) <--> Ember.Logger.error(msg)
, see: https://github.com/davewasmer/ember-cli-rollbar/blob/master/app/initializers/rollbar.js#L8The text was updated successfully, but these errors were encountered: