Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature request) Extension popup position #46

Open
ggunia opened this issue Nov 24, 2021 · 1 comment
Open

(Feature request) Extension popup position #46

ggunia opened this issue Nov 24, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ggunia
Copy link

ggunia commented Nov 24, 2021

I want to display browser actions vertically on the left side of the screen.

  • Support more orientation options for position browser action popups.
  • Supporting more orientations would also require overflow prevention (to make sure it stays within the boundaries of the screen)
@samuelmaddock
Copy link
Owner

Happy to accept contributions for this support. Currently it's an open todo in the code:

private updatePosition() {
if (!this.browserWindow || !this.parent) return
const winBounds = this.parent.getBounds()
const viewBounds = this.browserWindow.getBounds()
// TODO: support more orientations than just top-right
let x = winBounds.x + this.anchorRect.x + this.anchorRect.width - viewBounds.width
let y = winBounds.y + this.anchorRect.y + this.anchorRect.height + PopupView.POSITION_PADDING

@samuelmaddock samuelmaddock added enhancement New feature or request help wanted Extra attention is needed labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants