Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entities should be exported for people to use #124

Open
Jameskmonger opened this issue Sep 10, 2018 · 1 comment
Open

Entities should be exported for people to use #124

Jameskmonger opened this issue Sep 10, 2018 · 1 comment

Comments

@Jameskmonger
Copy link
Contributor

Jameskmonger commented Sep 10, 2018

Since the webpack removal, the typings now directly match the TypeScript code.

This means that anything we want exported must be explicitly exported.

Currently, it is not possible to import entities:

import Harvest, { ProjectAssignment, TimeEntry, Project, TaskAssignment, Task } from "harvest";
Module "harvest" has no exported member 'ProjectAssignment'
Module "harvest" has no exported member 'TimeEntry'
Module "harvest" has no exported member 'Project'
Module "harvest" has no exported member 'TaskAssignment'
Module "harvest" has no exported member 'Task '

The solution for this is to export them all from index.ts.

@simplyspoke
Copy link
Owner

That is a problem,

I have a timeblock on Friday where I should be able to dig a little deeper into this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants